Fix miscomputation of direct_lateral_relids for join relations.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 30 Nov 2020 17:22:43 +0000 (12:22 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 30 Nov 2020 17:22:43 +0000 (12:22 -0500)
commitb1738ff6ab73203cbbc02d7fb82941dbc061d301
treea2afd94d9f24e3f654d11a58d1276788d6630a1d
parent873ea9ee692e7829614f913685db540b17998ba6
Fix miscomputation of direct_lateral_relids for join relations.

If a PlaceHolderVar is to be evaluated at a join relation, but
its value is only needed there and not at higher levels, we neglected
to update the joinrel's direct_lateral_relids to include the PHV's
source rel.  This causes problems because join_is_legal() then won't
allow joining the joinrel to the PHV's source rel at all, leading
to "failed to build any N-way joins" planner failures.

Per report from Andreas Seltenreich.  Back-patch to 9.5
where the problem originated.

Discussion: https://postgr.es/m/87blfgqa4t.fsf@aurora.ydns.eu
src/backend/optimizer/util/placeholder.c
src/test/regress/expected/join.out
src/test/regress/sql/join.sql