Let table AM insertion methods control index insertion
authorAlexander Korotkov <akorotkov@postgresql.org>
Sat, 30 Mar 2024 20:39:03 +0000 (22:39 +0200)
committerAlexander Korotkov <akorotkov@postgresql.org>
Sat, 30 Mar 2024 20:53:56 +0000 (22:53 +0200)
commitb1484a3f1910bfd0e254afe40085dfc3351bda8c
tree329e9e84dba07d2b85487c4acb5ebb975836947b
parentc95c25f9af4bc77f2f66a587735c50da08c12b37
Let table AM insertion methods control index insertion

Previously, the executor did index insert unconditionally after calling
table AM interface methods tuple_insert() and multi_insert().  This commit
introduces the new parameter insert_indexes for these two methods.  Setting
'*insert_indexes' to true saves the current logic.  Setting it to false
indicates that table AM cares about index inserts itself and doesn't want the
caller to do that.

Discussion: https://postgr.es/m/CAPpHfdurb9ycV8udYqM%3Do0sPS66PJ4RCBM1g-bBpvzUfogY0EA%40mail.gmail.com
Reviewed-by: Pavel Borisov, Matthias van de Meent, Mark Dilger
12 files changed:
src/backend/access/heap/heapam.c
src/backend/access/heap/heapam_handler.c
src/backend/access/table/tableam.c
src/backend/catalog/indexing.c
src/backend/commands/copyfrom.c
src/backend/commands/createas.c
src/backend/commands/matview.c
src/backend/commands/tablecmds.c
src/backend/executor/execReplication.c
src/backend/executor/nodeModifyTable.c
src/include/access/heapam.h
src/include/access/tableam.h