Fix mishandling of OLD/NEW references in subqueries in rule actions.
authorDean Rasheed <dean.a.rasheed@gmail.com>
Sat, 25 Feb 2023 14:41:12 +0000 (14:41 +0000)
committerDean Rasheed <dean.a.rasheed@gmail.com>
Sat, 25 Feb 2023 14:41:12 +0000 (14:41 +0000)
commita7d71c41dbd691ac86cc47114dab9db4b31f27ad
tree4c7c2b47a7ab4ab87e3387c0e86f1905e3500ce2
parent05fc551796e82c451a6f2bc39d1eafb3be3d2657
Fix mishandling of OLD/NEW references in subqueries in rule actions.

If a rule action contains a subquery that refers to columns from OLD
or NEW, then those are really lateral references, and the planner will
complain if it sees such things in a subquery that isn't marked as
lateral. However, at rule-definition time, the user isn't required to
mark the subquery with LATERAL, and so it can fail when the rule is
used.

Fix this by marking such subqueries as lateral in the rewriter, at the
point where they're used.

Dean Rasheed and Tom Lane, per report from Alexander Lakhin.
Back-patch to all supported branches.

Discussion: https://postgr.es/m/5e09da43-aaba-7ea7-0a51-a2eb981b058b%40gmail.com
src/backend/rewrite/rewriteHandler.c
src/test/regress/expected/rules.out
src/test/regress/sql/rules.sql