Assign a child slot to every postmaster child process
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 14 Nov 2024 14:12:28 +0000 (16:12 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 14 Nov 2024 14:12:28 +0000 (16:12 +0200)
commita78af0427015449269fb7d9d8c6057cfcb740149
treeeae2ea6af8d455dd8d352d0e38f667ece481bfd5
parentbb861414fea31073f27aaab75a0ceaf3638d7985
Assign a child slot to every postmaster child process

Previously, only backends, autovacuum workers, and background workers
had an entry in the PMChildFlags array. With this commit, all
postmaster child processes, including all the aux processes, have an
entry. Dead-end backends still don't get an entry, though, and other
processes that don't touch shared memory will never mark their
PMChildFlags entry as active.

We now maintain separate freelists for different kinds of child
processes. That ensures that there are always slots available for
autovacuum and background workers. Previously, pre-authentication
backends could prevent autovacuum or background workers from starting
up, by using up all the slots.

The code to manage the slots in the postmaster process is in a new
pmchild.c source file. Because postmaster.c is just so large.
Assigning pmsignal slot numbers is now pmchild.c's responsibility.
This replaces the PMChildInUse array in pmsignal.c.

Some of the comments in postmaster.c still talked about the "stats
process", but that was removed in commit 5891c7a8ed. Fix those while
we're at it.

Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/a102f15f-eac4-4ff2-af02-f9ff209ec66f@iki.fi
15 files changed:
src/backend/bootstrap/bootstrap.c
src/backend/postmaster/Makefile
src/backend/postmaster/launch_backend.c
src/backend/postmaster/meson.build
src/backend/postmaster/pmchild.c [new file with mode: 0644]
src/backend/postmaster/postmaster.c
src/backend/postmaster/syslogger.c
src/backend/storage/ipc/pmsignal.c
src/backend/storage/lmgr/proc.c
src/backend/tcop/postgres.c
src/include/postmaster/bgworker_internals.h
src/include/postmaster/postmaster.h
src/include/postmaster/syslogger.h
src/include/storage/pmsignal.h
src/tools/pgindent/typedefs.list