Refactor basebackup.c's _tarWriteDir() function.
authorRobert Haas <rhaas@postgresql.org>
Tue, 12 Oct 2021 17:11:29 +0000 (13:11 -0400)
committerRobert Haas <rhaas@postgresql.org>
Tue, 12 Oct 2021 17:11:29 +0000 (13:11 -0400)
commit967a17fe2fa77b61061c8fb1183f64a5df4e080a
treedc91cbb913fdb36d35167db9ca76272f24359977
parentd9ddc50bafc062ec1ae7f98b886b7950102d87fc
Refactor basebackup.c's _tarWriteDir() function.

Sometimes, we replace a symbolic link that we find in the data
directory with an actual directory within the tarfile that we
create. _tarWriteDir was responsible both for making this
substitution and also for writing the tar header for the
resulting directory into the tar file. Make it do only the first
of those things, and rename to convert_link_to_directory.

Substantially larger refactoring of this source file is planned,
but this little bit seemed to make sense to commit
independently.

Discussion: http://postgr.es/m/CA+Tgmobz6tuv5tr-WxURe5JA1vVcGz85k4kkvoWxcyHvDpEqFA@mail.gmail.com
src/backend/replication/basebackup.c