Protect against overflow of ltree.numlevel and lquery.numlevel.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 28 Mar 2020 21:09:51 +0000 (17:09 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 28 Mar 2020 21:09:51 +0000 (17:09 -0400)
commit95f7ddfdad99c5ea0500d90ce52075814e10ed8c
tree106ff772a77202b5fecc90afe0856e5cfe5cea40
parent42750b08d946e2a5048454d7b4e127f0e1df3c65
Protect against overflow of ltree.numlevel and lquery.numlevel.

These uint16 fields could be overflowed by excessively long input,
producing strange results.  Complain for invalid input.

Likewise check for out-of-range values of the repeat counts in lquery.
(We don't try too hard on that one, notably not bothering to detect
if atoi's result has overflowed.)

Also detect length overflow in ltree_concat.

In passing, be more consistent about whether "syntax error" messages
include the type name.  Also, clarify the documentation about what
the size limit is.

This has been broken for a long time, so back-patch to all supported
branches.

Nikita Glukhov, reviewed by Benjie Gillam and Tomas Vondra

Discussion: https://postgr.es/m/CAP_rww=waX2Oo6q+MbMSiZ9ktdj6eaJj0cQzNu=Ry2cCDij5fw@mail.gmail.com
contrib/ltree/expected/ltree.out
contrib/ltree/ltree.h
contrib/ltree/ltree_io.c
contrib/ltree/ltree_op.c
contrib/ltree/sql/ltree.sql
doc/src/sgml/ltree.sgml