Add wait event for pg_usleep() in perform_spin_delay()
authorAndres Freund <andres@anarazel.de>
Tue, 22 Nov 2022 04:34:17 +0000 (20:34 -0800)
committerAndres Freund <andres@anarazel.de>
Tue, 22 Nov 2022 04:34:17 +0000 (20:34 -0800)
commit92daeca45df6551dd85f92f7369eaa57a35fb8a9
treeba02243ae9ee125666ea2aec25e50a95dc0927dd
parentbd82928625e7ebe40eaaa57f3b4d03bae19491de
Add wait event for pg_usleep() in perform_spin_delay()

The lwlock wait queue scalability issue fixed in a4adc31f690 was quite hard to
find because of the exponential backoff and because we adjust spins_per_delay
over time within a backend.

To make it easier to find similar issues in the future, add a wait event for
the pg_usleep() in perform_spin_delay(). Showing a wait event while spinning
without sleeping would increase the overhead of spinlocks, which we do not
want.

We may at some later point want to have more granular wait events, but that'd
be a substantial amount of work. This provides at least some insights into
something currently hard to observe.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com>
https://postgr.es/m/20221120204310.xywrhyxyytsajuuq@awork3.anarazel.de
doc/src/sgml/monitoring.sgml
src/backend/storage/lmgr/s_lock.c
src/backend/utils/activity/wait_event.c
src/include/utils/wait_event.h