Drop opcintype from index AM strategy translation API
authorPeter Eisentraut <peter@eisentraut.org>
Fri, 21 Feb 2025 07:34:35 +0000 (08:34 +0100)
committerPeter Eisentraut <peter@eisentraut.org>
Fri, 21 Feb 2025 08:07:16 +0000 (09:07 +0100)
commit7d6d2c4bbd730bd9af191d46d4fb01d5f5c30cf1
tree211eef7a0cd3b72f6bd182a708ff5f8191918110
parent7202d72787d3b93b692feae62ee963238580c877
Drop opcintype from index AM strategy translation API

The type argument wasn't actually really necessary.  It was a remnant
of converting the API of the gist strategy translation from using
opclass to using opfamily+opcintype (commits c09e5a6a016,
622f678c102).  For looking up the gist translation function, we used
the convention "amproclefttype = amprocrighttype = opclass's
opcintype" (see pg_amproc.h).  But each operator family should only
have one translation function, and getting the right type for the
lookup is sometimes cumbersome and fragile, so this is all
unnecessarily complicated.

To simplify this, change the gist stategy support procedure to take
"any", "any" as argument.  (This is arbitrary but seems intuitive.
The alternative of using InvalidOid as argument(s) upsets various DDL
commands, so it's not practical.)  Then we don't need opcintype for
the lookup, and we can remove it from all the API layers introduced by
commit c09e5a6a016.

This also adds some more documentation about the correct signature of
the gist support function and adds more checks in gistvalidate().
This was previously underspecified.  (It relied implicitly on
convention mentioned above.)

Discussion: https://www.postgresql.org/message-id/flat/E72EAA49-354D-4C2E-8EB9-255197F55330@enterprisedb.com
18 files changed:
contrib/btree_gist/btree_gist--1.7--1.8.sql
doc/src/sgml/gist.sgml
src/backend/access/gist/gistutil.c
src/backend/access/gist/gistvalidate.c
src/backend/access/hash/hash.c
src/backend/access/index/amapi.c
src/backend/access/nbtree/nbtree.c
src/backend/catalog/index.c
src/backend/commands/indexcmds.c
src/backend/commands/tablecmds.c
src/backend/executor/execReplication.c
src/backend/replication/logical/relation.c
src/include/access/amapi.h
src/include/access/gist.h
src/include/access/hash.h
src/include/access/nbtree.h
src/include/catalog/catversion.h
src/include/catalog/pg_amproc.dat