Fix ReadRecentBuffer for local buffers.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 25 Jul 2022 05:48:38 +0000 (08:48 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 25 Jul 2022 05:52:46 +0000 (08:52 +0300)
commit7a08f78aea95a7046816fe6a711e83615ccdb737
tree95f2a739e6c8331d23b5c82bb4f2f86ec5200c27
parent2387f52962e615eac937ed47de724e4d55ffffb7
Fix ReadRecentBuffer for local buffers.

It incorrectly used GetBufferDescriptor instead of
GetLocalBufferDescriptor, causing it to not find the correct buffer in
most cases, and performing an out-of-bounds memory read in the corner
case that temp_buffers > shared_buffers.

It also bumped the usage-count on the buffer, even if it was
previously pinned. That won't lead to crashes or incorrect results,
but it's different from what the shared-buffer case does, and
different from the usual code in LocalBufferAlloc. Fix that too, and
make the code ordering match LocalBufferAlloc() more closely, so that
it's easier to verify that it's doing the same thing.

Currently, ReadRecentBuffer() is only used with non-temp relations, in
WAL redo, so the broken code is currently dead code. However, it could
be used by extensions.

Backpatch-through: 14
Discussion: https://www.postgresql.org/message-id/2d74b46f-27c9-fb31-7f99-327a87184cc0%40iki.fi
Reviewed-by: Thomas Munro, Zhang Mingli, Richard Guo
src/backend/storage/buffer/bufmgr.c