remove_rel_from_query() must clean up PlaceHolderVar.phrels fields.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 8 Feb 2023 19:08:46 +0000 (14:08 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 8 Feb 2023 19:08:46 +0000 (14:08 -0500)
commit798c0176342150c8fe1404b0007b299db2e73ce0
tree3463c781263358e7ea19f6736ac784dfc0d81be0
parentb7e84c65d5b2d694a669ae1db8ab1d6c51ef8596
remove_rel_from_query() must clean up PlaceHolderVar.phrels fields.

While we got away with this sloppiness before, it's not okay now
that fee7b77b9 caused build_joinrel_tlist() to make use of phrels.
Per report from Robins Tharakan.

Richard Guo (some cosmetic tweaks by me)

Discussion: https://postgr.es/m/CAMbWs4_ngw9sKxpTE8hqk=-ooVX_CQP3DarA4HzkRMz_JKpTrA@mail.gmail.com
src/backend/optimizer/plan/analyzejoins.c
src/test/regress/expected/join.out
src/test/regress/sql/join.sql