Be more careful with error paths in pg_set_regex_collation().
authorJeff Davis <jdavis@postgresql.org>
Thu, 5 Sep 2024 19:10:08 +0000 (12:10 -0700)
committerJeff Davis <jdavis@postgresql.org>
Thu, 5 Sep 2024 19:10:08 +0000 (12:10 -0700)
commit7829f85a6285b3703a53ba5963a4df2e768014df
tree9a0f4c20c689106c1e6fadf7c03ac293630d1ad4
parentfadff3fc94598db1d87e4242821964fb2850e19e
Be more careful with error paths in pg_set_regex_collation().

Set global variables after error paths so that they don't end up in an
inconsistent state.

The inconsistent state doesn't lead to an actual problem, because
after an error, pg_set_regex_collation() will be called again before
the globals are accessed.

Change extracted from patch by Andreas Karlsson, though not discussed
explicitly.

Discussion: https://postgr.es/m/60929555-4709-40a7-b136-bcb44cff5a3c@proxel.se
src/backend/regex/regc_pg_locale.c