Remove buffers_backend and buffers_backend_fsync from pg_stat_checkpointer
authorMichael Paquier <michael@paquier.xyz>
Fri, 27 Oct 2023 02:16:39 +0000 (11:16 +0900)
committerMichael Paquier <michael@paquier.xyz>
Fri, 27 Oct 2023 02:16:39 +0000 (11:16 +0900)
commit74604a37f2f9eb6e626a4ff3cedd02aef5a2ad59
tree98c896ef510e28351b45e102e7c9970a0211c535
parent0c882a298881056176a27ccc44c5c3bb7c8f308c
Remove buffers_backend and buffers_backend_fsync from pg_stat_checkpointer

Two attributes related to checkpointer statistics are removed in this
commit:
- buffers_backend, that counts the number of buffers written directly by
a backend.
- buffers_backend_fsync, that counts the number of times a backend had
to do fsync() by its own.

These are actually not checkpointer properties but backend properties.
Also, pg_stat_io provides a more accurate and equivalent report of these
numbers, by tracking all the I/O stats related to backends, including
writes and fsyncs, so storing them in pg_stat_checkpointer was
redundant.

Thanks also to Robert Haas and Amit Kapila for their input.

Bump catalog version.

Author: Bharath Rupireddy
Reviewed-by: Bertrand Drouvot, Andres Freund
Discussion: https://postgr.es/m/20230210004604.mcszbscsqs3bc5nx@awork3.anarazel.de
doc/src/sgml/monitoring.sgml
src/backend/catalog/system_views.sql
src/backend/postmaster/checkpointer.c
src/backend/utils/activity/pgstat_checkpointer.c
src/backend/utils/adt/pgstatfuncs.c
src/include/catalog/catversion.h
src/include/catalog/pg_proc.dat
src/include/pgstat.h
src/test/regress/expected/rules.out