Don't use abort(3) in libpq's fe-print.c.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 28 Jun 2021 18:17:41 +0000 (14:17 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 28 Jun 2021 18:17:41 +0000 (14:17 -0400)
commit6f5d9bce57a7bb29ba61f0bf4fd465a26de9fc28
treec7bf1878eb0a57c223856ca3ad6c2cb8b9307a96
parent01697e92a460b10fde43707b29391c8deb69573e
Don't use abort(3) in libpq's fe-print.c.

Causing a core dump on out-of-memory seems pretty unfriendly,
and surely is far outside the expected behavior of a general-purpose
library.  Just print an error message (as we did already) and return.
These functions unfortunately don't have an error return convention,
but code using them is probably just looking for a quick-n-dirty
print method and wouldn't bother to check anyway.

Although these functions are semi-deprecated, it still seems
appropriate to back-patch this.  In passing, also back-patch
b90e6cef1, just to reduce cosmetic differences between the
branches.

Discussion: https://postgr.es/m/3122443.1624735363@sss.pgh.pa.us
src/interfaces/libpq/fe-print.c