Make rs_cindex and rs_ntuples unsigned
authorMelanie Plageman <melanieplageman@gmail.com>
Wed, 18 Dec 2024 16:47:38 +0000 (11:47 -0500)
committerMelanie Plageman <melanieplageman@gmail.com>
Wed, 18 Dec 2024 16:47:38 +0000 (11:47 -0500)
commit68d9662be1c4b705123a0e292974fb4be661294c
tree1e11a6b5953fe7ccc81c01c11168ff1b0d7e2358
parent1f0de66ea2a5549a3768c67434e28a136c280571
Make rs_cindex and rs_ntuples unsigned

HeapScanDescData.rs_cindex and rs_ntuples can't be less than 0. All scan
types using the heap scan descriptor expect these values to be >= 0.
Make that expectation clear by making rs_cindex and rs_ntuples unsigned.

Also remove the test in heapam_scan_bitmap_next_tuple() that checks if
rs_cindex < 0. This was never true, but now that rs_cindex is unsigned,
it makes even less sense.

While we are at it, initialize both rs_cindex and rs_ntuples to 0 in
initscan().

Author: Melanie Plageman
Reviewed-by: Dilip Kumar
Discussion: https://postgr.es/m/CAAKRu_ZxF8cDCM_BFi_L-t%3DRjdCZYP1usd1Gd45mjHfZxm0nZw%40mail.gmail.com
src/backend/access/heap/heapam.c
src/backend/access/heap/heapam_handler.c
src/include/access/heapam.h