pgstat: fix subscription stats entry leak.
authorMasahiko Sawada <msawada@postgresql.org>
Wed, 5 Jul 2023 05:49:46 +0000 (14:49 +0900)
committerMasahiko Sawada <msawada@postgresql.org>
Wed, 5 Jul 2023 05:49:46 +0000 (14:49 +0900)
commit68a59f9e99831cf05a746928a955781503232bbb
treec96be39ab2cc3e97fae4292ebfed715ad8f31813
parentcccdbc5d95aca276789bbe28783f3e06f9a3ba9c
pgstat: fix subscription stats entry leak.

Commit 7b64e4b3 taught DropSubscription() to drop stats entry of
subscription that is not associated with a replication slot for apply
worker at DROP SUBSCRIPTION but missed covering the case where the
subscription is not associated with replication slots for both apply
worker and tablesync worker.

Also add a test to verify that the stats for slot-less subscription is
removed at DROP SUBSCRIPTION time.

Backpatch down to 15.

Author: Masahiko Sawada
Reviewed-by: Nathan Bossart, Hayato Kuroda, Melih Mutlu, Amit Kapila
Discussion: https://postgr.es/m/CAD21AoB71zkP7uPT7JDPsZcvp0749ExEQnOJxeNKPDFisHar+w@mail.gmail.com
Backpatch-through: 15
src/backend/commands/subscriptioncmds.c
src/test/subscription/t/026_stats.pl