Remove memory leaks in isolationtester.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 27 Jun 2021 16:45:04 +0000 (12:45 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 27 Jun 2021 16:45:04 +0000 (12:45 -0400)
commit642c0697c96b9c6ba5d194653a329f7820565f01
treef71c56565432e7f36f0f03fc06e6da91a2a35c6a
parentc302a6139072fed9410204fa9e751d95930e05ff
Remove memory leaks in isolationtester.

specscanner.l leaked a kilobyte of memory per token of the spec file.
Apparently somebody thought that the introductory code block would be
executed once; but it's once per yylex() call.

A couple of functions in isolationtester.c leaked small amounts of
memory due to not bothering to free one-time allocations.  Might
as well improve these so that valgrind gives this program a clean
bill of health.  Also get rid of an ugly static variable.

Coverity complained about one of the one-time leaks, which led me
to try valgrind'ing isolationtester, which led to discovery of the
larger leak.
src/test/isolation/isolationtester.c
src/test/isolation/specscanner.l