Avoid using large pass-by-value struct arguments in pgbench.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 27 Mar 2022 18:38:05 +0000 (14:38 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 27 Mar 2022 18:38:05 +0000 (14:38 -0400)
commit641a9b716789628a4e7403ecef1b82cc4a9552b0
tree15b78704b0034828b0d95b6e2bb5dc77a8340f70
parent0fb6954aa5012fc0c41af364fb328f90e648f6b7
Avoid using large pass-by-value struct arguments in pgbench.

In the wake of commit 4a39f87ac, which noticeably increased the
size of struct StatsData and thereby ParsedScript, Coverity started
to complain that ParsedScript was unreasonably large to be passing
by value.  The two places that do this are only used during setup,
so they're not really dragging down benchmark measurements --- but
gratuitous inefficiency is not a good look in a benchmarking program.
Convert to use pointers instead.
src/bin/pgbench/pgbench.c