Avoid dangling-pointer usage in pg_basebackup progress reports.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 17 Feb 2022 20:03:40 +0000 (15:03 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 17 Feb 2022 20:03:40 +0000 (15:03 -0500)
commit62cb7427d1e491faf8612a82c2e3711a8cd65422
tree981a7b142a4e0dc81cb6c94cd438b526ce8c2cbc
parent138c51b72168e7b57c9edb4e9935274d3abf6bed
Avoid dangling-pointer usage in pg_basebackup progress reports.

Ill-considered refactoring in 23a1c6578 led to progress_filename
sometimes pointing to data that had gone out of scope.  The most
bulletproof fix is to hang onto a copy of whatever's passed in.
Compared to the work spent elsewhere per file, that's not very
expensive, plus we can skip it except in verbose logging mode.

Per buildfarm.

Discussion: https://postgr.es/m/20220212211316.GK31460@telsasoft.com
src/bin/pg_basebackup/pg_basebackup.c