Dissociate btequalimage() from interval_ops, ending its deduplication.
authorNoah Misch <noah@leadboat.com>
Sat, 14 Oct 2023 23:33:51 +0000 (16:33 -0700)
committerNoah Misch <noah@leadboat.com>
Sat, 14 Oct 2023 23:33:51 +0000 (16:33 -0700)
commit5f27b5f848a433ba54c521ccb889788b8f4d6ba7
tree88f846e810c8a398148c1cef63b9de252b51b197
parent90ebcc32d9829204bfd15db82ece3aacd84f40d6
Dissociate btequalimage() from interval_ops, ending its deduplication.

Under interval_ops, some equal values are distinguishable.  One such
pair is '24:00:00' and '1 day'.  With that being so, btequalimage()
breaches the documented contract for the "equalimage" btree support
function.  This can cause incorrect results from index-only scans.
Users should REINDEX any btree indexes having interval-type columns.
After updating, pg_amcheck will report an error for almost all such
indexes.  This fix makes interval_ops simply omit the support function,
like numeric_ops does.  Back-pack to v13, where btequalimage() first
appeared.  In back branches, for the benefit of old catalog content,
btequalimage() code will return false for type "interval".  Going
forward, back-branch initdb will include the catalog change.

Reviewed by Peter Geoghegan.

Discussion: https://postgr.es/m/20231011013317.22.nmisch@google.com
contrib/amcheck/verify_nbtree.c
src/include/catalog/catversion.h
src/include/catalog/pg_amproc.dat
src/include/catalog/pg_opfamily.dat
src/test/regress/expected/opr_sanity.out