Fix race condition in startup progress reporting.
authorRobert Haas <rhaas@postgresql.org>
Fri, 29 Oct 2021 18:40:15 +0000 (14:40 -0400)
committerRobert Haas <rhaas@postgresql.org>
Fri, 29 Oct 2021 18:40:15 +0000 (14:40 -0400)
commit5ccceb2946d4104804f8dca67515b602f5e78cdd
tree41a77009aac45625f6ca7b226e4dcd948b21167a
parent2f5c4397c39dea49c5608ba583868e26d767fc32
Fix race condition in startup progress reporting.

Commit 9ce346eabf350a130bba46be3f8c50ba28506969 added startup
progress reporting, but begin_startup_progress_phase has a race
condition: the timeout for the previous phase might fire just
before we reschedule the interrupt for the next phase.

To avoid the race, disable the timeout, clear the flag, and then
re-enable the timeout.

Patch by me, reviewed by Nitin Jadhav.

Discussion: https://postgr.es/m/CA+TgmoYq38i6iAzfRLVxA6Cm+wMCf4WM8wC3o_a+X_JvWC8bJg@mail.gmail.com
src/backend/postmaster/startup.c