Robustify tuplesort's free_sort_tuple function
authorDavid Rowley <drowley@postgresql.org>
Tue, 13 Jul 2021 01:27:05 +0000 (13:27 +1200)
committerDavid Rowley <drowley@postgresql.org>
Tue, 13 Jul 2021 01:27:05 +0000 (13:27 +1200)
commit5bd38d2f2846c7e387d04a16c4372da0de7b1221
tree8779bde858f5ae24c3b5cc3d4793966fcba61145
parent41469253e970b539a4ae75226dd4f226b7b2bc8c
Robustify tuplesort's free_sort_tuple function

41469253e went to the trouble of removing a theoretical bug from
free_sort_tuple by checking if the tuple was NULL before freeing it. Let's
make this a little more robust by also setting the tuple to NULL so that
should we be called again we won't end up doing a pfree on the already
pfree'd tuple. Per advice from Tom Lane.

Discussion: https://postgr.es/m/3188192.1626136953@sss.pgh.pa.us
Backpatch-through: 9.6, same as 41469253e
src/backend/utils/sort/tuplesort.c