Get rid of adjust_appendrel_attr_needed(), which has been broken ever since
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 11 Nov 2008 18:13:54 +0000 (18:13 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 11 Nov 2008 18:13:54 +0000 (18:13 +0000)
commit5aa70422df0ef37fcc995d63bb9a5113805c0f69
treebca11505d2890eaa41e8186b12d9ce5669096814
parent8f74153732c512baa498eb6c38244c0d3a09dff8
Get rid of adjust_appendrel_attr_needed(), which has been broken ever since
we extended the appendrel mechanism to support UNION ALL optimization.  The
reason nobody noticed was that we are not actually using attr_needed data for
appendrel children; hence it seems more reasonable to rip it out than fix it.
Back-patch to 8.2 because an Assert failure is possible in corner cases.
Per examination of an example from Jim Nasby.

In HEAD, also get rid of AppendRelInfo.col_mappings, which is quite inadequate
to represent UNION ALL situations; depend entirely on translated_vars instead.
src/backend/optimizer/path/allpaths.c
src/backend/optimizer/prep/prepunion.c
src/include/optimizer/prep.h