Fix handling of multiple AFTER ROW triggers on a foreign table.
authorEtsuro Fujita <efujita@postgresql.org>
Tue, 10 Dec 2019 09:00:30 +0000 (18:00 +0900)
committerEtsuro Fujita <efujita@postgresql.org>
Tue, 10 Dec 2019 09:00:30 +0000 (18:00 +0900)
commit5a20b0219e7684788a1b63e812dd44b31361b259
treee4bde3390e3ee82a90a5cf19f748aeec8be2506e
parent28e6a2fd6358c1b75ce2f4e7cb3fcff979dbe539
Fix handling of multiple AFTER ROW triggers on a foreign table.

AfterTriggerExecute() retrieves a fresh tuple or pair of tuples from a
tuplestore and then stores the tuple(s) in the passed-in slot(s) if
AFTER_TRIGGER_FDW_FETCH, while it uses the most-recently-retrieved
tuple(s) stored in the slot(s) if AFTER_TRIGGER_FDW_REUSE.  This was
done correctly before 12, but commit ff11e7f4b broke it by mistakenly
clearing the tuple(s) stored in the slot(s) in that function, leading to
an assertion failure as reported in bug #16139 from Alexander Lakhin.

Also, fix some other issues with the aforementioned commit in passing:

* For tg_newslot, which is a slot added to the TriggerData struct by the
  commit to store new updated tuples, it didn't ensure the slot was NULL
  if there was no such tuple.
* The commit failed to update the documentation about the trigger
  interface.

Author: Etsuro Fujita
Backpatch-through: 12
Discussion: https://postgr.es/m/16139-94f9ccf0db6119ec%40postgresql.org
contrib/postgres_fdw/expected/postgres_fdw.out
contrib/postgres_fdw/sql/postgres_fdw.sql
doc/src/sgml/trigger.sgml
src/backend/commands/trigger.c