Update TransactionXmin when MyProc->xmin is updated
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Sat, 21 Dec 2024 21:42:39 +0000 (23:42 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Sat, 21 Dec 2024 21:42:39 +0000 (23:42 +0200)
commit578a7fe7b6f8484f6d7caa2fda288abb3fe87aa0
tree02d74e1bf71a790b3657d8d389ab0876012a44c6
parentdb448ce5ad36a2754e4e75900b180260143aacf8
Update TransactionXmin when MyProc->xmin is updated

GetSnapshotData() set TransactionXmin = MyProc->xmin, but when
SnapshotResetXmin() advanced MyProc->xmin, it did not advance
TransactionXmin correspondingly. That meant that TransactionXmin could
be older than MyProc->xmin, and XIDs between than TransactionXmin and
the real MyProc->xmin could be vacuumed away. One known consequence is
in pg_subtrans lookups: we might try to look up the status of an XID
that was already truncated away.

Back-patch to all supported versions.

Reviewed-by: Andres Freund
Discussion: https://www.postgresql.org/message-id/d27a046d-a1e4-47d1-a95c-fbabe41debb4@iki.fi
src/backend/utils/time/snapmgr.c