Remove misleading read stream asserts in a few users
authorMelanie Plageman <melanieplageman@gmail.com>
Thu, 3 Apr 2025 22:22:37 +0000 (18:22 -0400)
committerMelanie Plageman <melanieplageman@gmail.com>
Thu, 3 Apr 2025 22:22:37 +0000 (18:22 -0400)
commit54a3615f15b9b2e1433bc47cfb150317885d7c1f
treed6d75e266f08e0ef754be90364076e5d7de62e5e
parentdbd437e670b88ca67f6b2477e853412a0e82a8cc
Remove misleading read stream asserts in a few users

Several read stream users asserted that the read stream was exhausted
after looping on that very condition. It was pointed out in an a
review of an as-of-yet uncommitted read stream user [1] that this was
confusing and could lead the reader to think there was a possibility of
some kind of race condition. Remove these asserts.

[1] https://postgr.es/m/F9ACE8D0-B807-4A17-B6BD-87EF0717983D%40yesql.se
contrib/amcheck/verify_heapam.c
src/backend/access/gist/gistvacuum.c
src/backend/access/nbtree/nbtree.c
src/backend/access/spgist/spgvacuum.c