Rename force_parallel_mode to debug_parallel_query
authorDavid Rowley <drowley@postgresql.org>
Wed, 15 Feb 2023 08:21:59 +0000 (21:21 +1300)
committerDavid Rowley <drowley@postgresql.org>
Wed, 15 Feb 2023 08:21:59 +0000 (21:21 +1300)
commit5352ca22e0012d48055453ca9992a9515d811291
treeb247f2abbca2b0198280a69117a175c93fe4241b
parent8e0e0698f12bd77da38f6863ecdbe88a63ed49dc
Rename force_parallel_mode to debug_parallel_query

force_parallel_mode is meant to be used to allow us to exercise the
parallel query infrastructure to ensure that it's working as we expect.
It seems some users think this GUC is for forcing the query planner into
picking a parallel plan regardless of the costs.  A quick look at the
documentation would have made them realize that they were wrong, but the
GUC is likely too conveniently named which, evidently, seems to often
result in users expecting that it forces the planner into usefully
parallelizing queries.

Here we rename the GUC to something which casual users are less likely to
mistakenly think is what they need to make their query run more quickly.

For now, the old name can still be used.  We'll revisit if the old name
mapping can be removed once the buildfarm configs are all updated.

Reviewed-by: John Naylor
Discussion: https://postgr.es/m/CAApHDvrsOi92_uA7PEaHZMH-S4Xv+MGhQWA+GrP8b1kjpS1HjQ@mail.gmail.com
23 files changed:
doc/src/sgml/config.sgml
doc/src/sgml/regress.sgml
src/backend/access/transam/parallel.c
src/backend/commands/explain.c
src/backend/optimizer/plan/planmain.c
src/backend/optimizer/plan/planner.c
src/backend/utils/misc/guc.c
src/backend/utils/misc/guc_tables.c
src/include/optimizer/optimizer.h
src/pl/plpgsql/src/pl_exec.c
src/test/isolation/expected/deadlock-parallel.out
src/test/isolation/specs/deadlock-parallel.spec
src/test/isolation/specs/serializable-parallel.spec
src/test/modules/libpq_pipeline/libpq_pipeline.c
src/test/modules/test_oat_hooks/test_oat_hooks.c
src/test/regress/expected/multirangetypes.out
src/test/regress/expected/rangetypes.out
src/test/regress/expected/select_parallel.out
src/test/regress/expected/with.out
src/test/regress/sql/multirangetypes.sql
src/test/regress/sql/rangetypes.sql
src/test/regress/sql/select_parallel.sql
src/test/regress/sql/with.sql