Fix leak of LLVM "fatal-on-oom" section counter.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 5 Jul 2023 10:13:13 +0000 (13:13 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 5 Jul 2023 10:13:13 +0000 (13:13 +0300)
commit4f4d73466d71976b58f29121bab9d9fef6f3436e
tree1735f70e91c9bbd2c980ef82048f536948450dd7
parent088539015173a204839a53d1d0fc8fa8c96783ba
Fix leak of LLVM "fatal-on-oom" section counter.

llvm_release_context() called llvm_enter_fatal_on_oom(), but was missing
the corresponding llvm_leave_fatal_on_oom() call. As a result, if JIT was
used at all, we were almost always in the "fatal-on-oom" state.

It only makes a difference if you use an extension written in C++, and
run out of memory in a C++ 'new' call. In that case, you would get a
PostgreSQL FATAL error, instead of the default behavior of throwing a
C++ exception.

Back-patch to all supported versions.

Reviewed-by: Daniel Gustafsson
Discussion: https://www.postgresql.org/message-id/54b78cca-bc84-dad8-4a7e-5b56f764fab5@iki.fi
src/backend/jit/llvm/llvmjit.c