Clean up error messages related to bad datetime units.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 3 Jan 2022 19:05:03 +0000 (14:05 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 3 Jan 2022 19:05:03 +0000 (14:05 -0500)
commit4b160492b9b8345747dfcad468eb89e9ccc0a876
treedddf14c63034af0210746472e5870058dcf9d205
parentba2bc4a7bace6db6657b4e550b11137e31e2f8dc
Clean up error messages related to bad datetime units.

Adjust the error texts used for unrecognized/unsupported datetime
units so that there are just two strings to translate, not two
per datatype.  Along the way, follow our usual error message style
of not double-quoting type names, and instead making sure that we
say the name is a type.  Fix a couple of places in date.c that
were using the wrong one of "unrecognized" and "unsupported".

Nikhil Benesch, with a bit more editing by me

Discussion: https://postgr.es/m/CAPWqQZTURGixmbMH2_Z3ZtWGA0ANjUb9bwtkkxSxSfDeFHuM6Q@mail.gmail.com
src/backend/utils/adt/date.c
src/backend/utils/adt/timestamp.c
src/test/regress/expected/date.out
src/test/regress/expected/interval.out
src/test/regress/expected/time.out
src/test/regress/expected/timetz.out