Remove configure's check for rl_completion_append_character.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 3 Feb 2022 04:01:56 +0000 (23:01 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 3 Feb 2022 04:01:56 +0000 (23:01 -0500)
commit4b0e37faaf5ffe1552a07438323341c6394890da
treec24069feb0ccbda5de592cf292e27cfd07e0e01f
parent9d179d9c23b9d4cc1a4ffa02e4de79114de064d7
Remove configure's check for rl_completion_append_character.

The comment for PGAC_READLINE_VARIABLES says "Readline versions < 2.1
don't have rl_completion_append_character".  It seems certain that such
versions are extinct in the wild, though; for sure there are none in the
buildfarm.  Libedit has had this variable for at least twenty years too.
Also, tab-complete.c's behavior without it is quite unfriendly, since
we'll emit a space even when completion fails; but we've had no
complaints about that.

Therefore, let's assume this variable is always there, and drop the
configure check to save a few build cycles.

Discussion: https://postgr.es/m/147685.1643858911@sss.pgh.pa.us
config/programs.m4
configure
src/bin/psql/tab-complete.c
src/include/pg_config.h.in
src/tools/msvc/Solution.pm