Remove now-dead code in StoreAttrDefault().
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 3 Mar 2025 18:09:20 +0000 (13:09 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 3 Mar 2025 18:09:20 +0000 (13:09 -0500)
commit4528768d98f83070d625207dcb526982fb18f1ce
treede834314024ffdfbe0101f03416ebb6177f723d8
parent95f650674d2ceea1ba6440a9b0ae89ed3867fd7e
Remove now-dead code in StoreAttrDefault().

StoreAttrDefault() is no longer responsible for filling
attmissingval, so remove the code for that.

Get rid of RawColumnDefault.missingMode, too, as we no longer
need that to pass information around.

While here, clean up some sloppy coding in StoreAttrDefault(),
such as failure to use XXXGetDatum macros.  These aren't bugs
but they're not good code either.

Reported-by: jian he <jian.universality@gmail.com>
Author: jian he <jian.universality@gmail.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CACJufxHFssPvkP1we7WMhPD_1kwgbG52o=kQgL+TnVoX5LOyCQ@mail.gmail.com
src/backend/catalog/heap.c
src/backend/catalog/pg_attrdef.c
src/backend/commands/tablecmds.c
src/include/catalog/heap.h
src/include/catalog/pg_attrdef.h