Remove incorrect Asserts in buffile.c
authorDavid Rowley <drowley@postgresql.org>
Wed, 3 Jul 2024 21:44:34 +0000 (09:44 +1200)
committerDavid Rowley <drowley@postgresql.org>
Wed, 3 Jul 2024 21:44:34 +0000 (09:44 +1200)
commit4331a11c62eca7426ad4472be051fe512a04fc80
treecce4c15fb2fb0d08c0a573d258f8a5d241bc3f41
parent2329cad1b93f268c0ec6848732c6db43eb46156c
Remove incorrect Asserts in buffile.c

Both BufFileSize() and BufFileAppend() contained Asserts to ensure the
given BufFile(s) had a valid fileset.  A valid fileset isn't required in
either of these functions, so remove the Asserts and adjust the
comments accordingly.

This was noticed while work was being done on a new patch to call
BufFileSize() on a BufFile without a valid fileset.  It seems there's
currently no code in the tree which could trigger these Asserts, so no
need to backpatch this, for now.

Reviewed-by: Peter Geoghegan, Matthias van de Meent, Tom Lane
Discussion: https://postgr.es/m/CAApHDvofgZT0VzydhyGH5MMb-XZzNDqqAbzf1eBZV5HDm3%2BosQ%40mail.gmail.com
src/backend/storage/file/buffile.c