Refactor datetime functions' timezone lookup code to reduce duplication.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 17 Mar 2023 21:47:15 +0000 (17:47 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 17 Mar 2023 21:47:19 +0000 (17:47 -0400)
commit3e59e5048d0f20debe4ad79b2e02ca2a76c5daed
tree2180e041471bef69c7f7b515ce65cd01be31c48d
parentcc1392d4aa5206d6b4dcc1b036f7a001bcac4197
Refactor datetime functions' timezone lookup code to reduce duplication.

We already had five copies of essentially the same logic, and an
upcoming patch introduces yet another use-case.  That's past my
threshold of pain, so introduce a common subroutine.  There's not
that much net code savings, but the chance of typos should go down.

Inspired by a patch from Przemysław Sztoch, but different in detail.

Discussion: https://postgr.es/m/01a84551-48dd-1359-bf7e-f6b0203a6bd0@sztoch.pl
src/backend/utils/adt/date.c
src/backend/utils/adt/datetime.c
src/backend/utils/adt/timestamp.c
src/include/utils/datetime.h