Improve assertion in FindReplTupleInLocalRel().
authorAmit Kapila <akapila@postgresql.org>
Wed, 11 Sep 2024 03:48:23 +0000 (09:18 +0530)
committerAmit Kapila <akapila@postgresql.org>
Wed, 11 Sep 2024 03:48:23 +0000 (09:18 +0530)
commit3beb945da9d72a9803180deb1752cf8feeb66883
treeea61ad686e02a0414b1ea8ea6b500b585af3675a
parent65c310b310a613d86c1ba94891fa9972587e09fd
Improve assertion in FindReplTupleInLocalRel().

The first part of the assertion verifying that the passed index must be PK
or RI was incorrectly passing index relation instead of heap relation in
GetRelationIdentityOrPK(). The assertion was not failing because the
second part of the assertion which needs to be performed only when remote
relation has REPLICA_IDENTITY_FULL set was also incorrect.

The change is not backpatched because the current coding doesn't lead to
any failure.

Reported-by: Dilip Kumar
Author: Amit Kapila
Reviewed-by: Vignesh C
Discussion: https://postgr.es/m/CAFiTN-tmguaT1DXbCC+ZomZg-oZLmU6BPhr0po7akQSG6vNJrg@mail.gmail.com
src/backend/replication/logical/worker.c