Explain dropdb can't use syscache because of TOAST
authorTomas Vondra <tomas.vondra@postgresql.org>
Mon, 19 Aug 2024 11:31:51 +0000 (13:31 +0200)
committerTomas Vondra <tomas.vondra@postgresql.org>
Mon, 19 Aug 2024 11:47:07 +0000 (13:47 +0200)
commit3acbe198e2ad0f7d790d04f87c662ee26738536a
treefa2173fddc646d7ecb32cf87c8cc405f2ff4ce29
parent8cea8c023edfc8ab8eadd4e68a9686727f494aaf
Explain dropdb can't use syscache because of TOAST

Add a comment explaining dropdb() can't rely on syscache. The issue with
flattened rows was fixed by commit 0f92b230f88b, but better to have
a clear explanation why the systable scan is necessary. The other places
doing in-place updates on pg_database have the same comment.

Suggestion and patch by Yugo Nagata. Backpatch to 12, same as the fix.

Author: Yugo Nagata
Backpatch-through: 12
Discussion: https://postgr.es/m/CAJTYsWWNkCt+-UnMhg=BiCD3Mh8c2JdHLofPxsW3m2dkDFw8RA@mail.gmail.com
src/backend/commands/dbcommands.c