Make pg_upgrade log message with control file path translatable.
authorFujii Masao <fujii@postgresql.org>
Fri, 18 Apr 2025 09:35:40 +0000 (18:35 +0900)
committerFujii Masao <fujii@postgresql.org>
Fri, 18 Apr 2025 09:35:40 +0000 (18:35 +0900)
commit3aad76a0a970faf22ea38dd61b5668d480b5a92f
tree141a02316d1fc9a72bffbb99a8f6c9215e5ec072
parent05883bd6e556bb4d86c7ece4c37080d00cdb0d34
Make pg_upgrade log message with control file path translatable.

Commit 173c97812ff replaced the hardcoded "global/pg_control" in pg_upgrade
log message with a string literal concatenation of XLOG_CONTROL_FILE macro.
However, this change made the message untranslatable.

This commit fixes the issue by using %s with XLOG_CONTROL_FILE instead of
that literal concatenation, allowing the message to be translated properly.
It also wraps the file path in double quotes for consistency with similar
log messages.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-by: Masao Fujii <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/20250407.155546.2129693791769531891.horikyota.ntt@gmail.com
src/bin/pg_upgrade/controldata.c