pg_rewind: Refactor the abstraction to fetch from local/libpq source.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 4 Nov 2020 09:21:18 +0000 (11:21 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 4 Nov 2020 09:21:18 +0000 (11:21 +0200)
commit37d2ff38031262a1778bc76a9c55fff7afbcf275
tree309e1c231f9acfbd012c139b816cf5384b00d52a
parentf81e97d0475cd4bc597adc23b665bd84fbf79a0d
pg_rewind: Refactor the abstraction to fetch from local/libpq source.

This makes the abstraction of a "source" server more clear, by introducing
a common abstract class, borrowing the object-oriented programming term,
that represents all the operations that can be done on the source server.
There are two implementations of it, one for fetching via libpq, and
another to fetch from a local directory. This adds some code, but makes it
easier to understand what's going on.

The copy_executeFileMap() and libpq_executeFileMap() functions contained
basically the same logic, just calling different functions to fetch the
source files. Refactor so that the common logic is in one place, in a new
function called perform_rewind().

Reviewed-by: Kyotaro Horiguchi, Soumyadeep Chakraborty
Discussion: https://www.postgresql.org/message-id/0c5b3783-af52-3ee5-f8fa-6e794061f70d%40iki.fi
12 files changed:
src/bin/pg_rewind/Makefile
src/bin/pg_rewind/copy_fetch.c [deleted file]
src/bin/pg_rewind/fetch.c [deleted file]
src/bin/pg_rewind/fetch.h [deleted file]
src/bin/pg_rewind/file_ops.c
src/bin/pg_rewind/file_ops.h
src/bin/pg_rewind/libpq_source.c [moved from src/bin/pg_rewind/libpq_fetch.c with 65% similarity]
src/bin/pg_rewind/local_source.c [new file with mode: 0644]
src/bin/pg_rewind/pg_rewind.c
src/bin/pg_rewind/pg_rewind.h
src/bin/pg_rewind/rewind_source.h [new file with mode: 0644]
src/tools/pgindent/typedefs.list