pg_dump: Refactor code that constructs ALTER ... OWNER TO commands
authorPeter Eisentraut <peter@eisentraut.org>
Wed, 2 Nov 2022 21:17:27 +0000 (17:17 -0400)
committerPeter Eisentraut <peter@eisentraut.org>
Wed, 2 Nov 2022 21:24:38 +0000 (17:24 -0400)
commit3655b46aa0b8156aced0b9ee3d10875632f84407
tree0da6c1c4e70b5b103d085f439aa05dd644775d19
parentbe541efbfd11c4339222935899989d9c65737ac6
pg_dump: Refactor code that constructs ALTER ... OWNER TO commands

Avoid having to list all the possible object types twice.  Instead,
only _getObjectDescription() needs to know about specific object
types.  It communicates back to _printTocEntry() whether an owner is
to be set.

In passing, remove the logic to use ALTER TABLE to set the owner of
views and sequences.  This is no longer necessary.  Furthermore, if
pg_dump doesn't recognize the object type, this is now a fatal error,
not a warning.

Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/0a00f923-599a-381b-923f-0d802a727715@enterprisedb.com
src/bin/pg_dump/pg_backup_archiver.c