Fix incorrect permissions on pg_subscription.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 3 Jun 2021 18:54:06 +0000 (14:54 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 3 Jun 2021 18:54:06 +0000 (14:54 -0400)
commit3590680b85a8e51ef8df550e5a10dedd0d2dfd88
treed6e08b21c4ccb1ad59b7868f6b97ee38971a6e01
parent187682c3217375c9b70417bf3235790f639e8e7e
Fix incorrect permissions on pg_subscription.

The documented intent is for all columns except subconninfo to be
publicly readable.  However, this has been overlooked twice.
subsynccommit has never been readable since it was introduced,
nor has the oid column (which is important for joining).

Given the lack of previous complaints, it's not clear that it's
worth doing anything about this in the back branches.  But there's
still time to fix it inexpensively for v14.

Per report from Israel Barth (via Euler Taveira).

Patch by Euler Taveira, possibly-vain comment updates by me.

Discussion: https://postgr.es/m/b8f7c17c-0041-46b6-acfe-2d1f5a985ab4@www.fastmail.com
src/backend/catalog/system_views.sql
src/include/catalog/catversion.h
src/include/catalog/pg_subscription.h