Remove reltarget_has_non_vars flag.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 10 Jun 2016 20:20:03 +0000 (16:20 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 10 Jun 2016 20:20:03 +0000 (16:20 -0400)
commit3303ea1a327b41d3b406d7be7a5ce2901e561066
treed3efb62c93fa191a290e101a7766b2e0f58f27dd
parent2f153ddfdd318b211590dd5585f65f357d85c2de
Remove reltarget_has_non_vars flag.

Commit b12fd41c6 added a "reltarget_has_non_vars" field to RelOptInfo,
but failed to maintain it accurately.  Since its only purpose was to skip
calls to has_parallel_hazard() in the simple case where a rel's targetlist
is all Vars, and that call is really pretty cheap in that case anyway, it
seems like this is just a case of premature optimization.  Let's drop the
flag and do the calls unconditionally until it's proven that we need more
smarts here.
src/backend/nodes/outfuncs.c
src/backend/optimizer/path/allpaths.c
src/backend/optimizer/util/placeholder.c
src/backend/optimizer/util/relnode.c
src/include/nodes/relation.h