Fix TestLib::slurp_file() with offset on windows.
authorAndres Freund <andres@anarazel.de>
Mon, 4 Oct 2021 20:28:06 +0000 (13:28 -0700)
committerAndres Freund <andres@anarazel.de>
Mon, 4 Oct 2021 20:28:06 +0000 (13:28 -0700)
commit2f74db1236fe83e6665e5b0ddad4454c69495614
tree028bdc198942c3a87231d5308eaa6e6b60b8c747
parent8162464a25e5314e753c580389f76a9b7f69445b
Fix TestLib::slurp_file() with offset on windows.

3c5b0685b921 used setFilePointer() to set the position of the filehandle, but
passed the wrong filehandle, always leaving the position at 0. Instead of just
fixing that, remove use of setFilePointer(), we have a perl fd at this point,
so we can just use perl's seek().

Additionally, the perl filehandle wasn't closed, just the windows filehandle.

Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de
Backpatch: 9.6-, like 3c5b0685b921
src/test/perl/TestLib.pm