Speedup and increase usability of set proc title functions
authorDavid Rowley <drowley@postgresql.org>
Mon, 20 Feb 2023 03:18:27 +0000 (16:18 +1300)
committerDavid Rowley <drowley@postgresql.org>
Mon, 20 Feb 2023 03:18:27 +0000 (16:18 +1300)
commit2cb82e2acfba069d00c6bd253d58df03d315672a
tree12d9873bb0cca1dd03a4e638f0318eb3c8287b45
parentde2aca288569fd0cabb425c0858e92e2c8c938cb
Speedup and increase usability of set proc title functions

The setting of the process title could be seen on profiles of very
fast-to-execute queries.  In many locations where we call
set_ps_display() we pass along a string constant, the length of which is
known during compilation.  Here we effectively rename set_ps_display() to
set_ps_display_with_len() and then add a static inline function named
set_ps_display() which calls strlen() on the given string.  This allows
the compiler to optimize away the strlen() call when dealing with
call sites passing a string constant.  We can then also use memcpy()
instead of strlcpy() to copy the string into the destination buffer.
That's significantly faster than strlcpy's byte-at-a-time way of
copying.

Here we also take measures to improve some code which was adjusting the
process title to add a " waiting" suffix to it.  Call sites which require
this can now just call set_ps_display_suffix() to add or adjust the suffix
and call set_ps_display_remove_suffix() to remove it again.

Reviewed-by: Andres Freund
Discussion: https://postgr.es/m/CAApHDvocBvvk-0gWNA2Gohe+sv9fMcv+fK_G+siBKJrgDG4O7g@mail.gmail.com
src/backend/replication/syncrep.c
src/backend/storage/buffer/bufmgr.c
src/backend/storage/ipc/standby.c
src/backend/storage/lmgr/lock.c
src/backend/tcop/postgres.c
src/backend/utils/misc/ps_status.c
src/include/utils/ps_status.h