Fix overflow danger in SampleHeapTupleVisible()
authorMelanie Plageman <melanieplageman@gmail.com>
Wed, 18 Dec 2024 23:16:43 +0000 (18:16 -0500)
committerMelanie Plageman <melanieplageman@gmail.com>
Wed, 18 Dec 2024 23:16:43 +0000 (18:16 -0500)
commit28328ec87b45725f62bed1104d99c8b3220d1675
treed405f96d14588809eb6894995b74c631b3b4ddf0
parent68d9662be1c4b705123a0e292974fb4be661294c
Fix overflow danger in SampleHeapTupleVisible()

68d9662be1c4b70 made HeapScanDesc->rs_ntuples unsigned but neglected to
change how it was being used in SampleHeapTupleVisible().

Return early if rs_ntuples is 0 to avoid overflowing and incorrectly
executing the loop code in SampleHeapTupleVisible().

Reported-by: Ranier Vilela
Discussion: https://postgr.es/m/CAEudQAot_xQoZyPZjpj1aBUPrPykY5mOPHGyvfe%3Djz%2BWowdA3A%40mail.gmail.com
src/backend/access/heap/heapam_handler.c