Avoid "you don't own a lock of type ExclusiveLock" in GRANT TABLESPACE.
authorNoah Misch <noah@leadboat.com>
Mon, 25 Nov 2024 22:42:35 +0000 (14:42 -0800)
committerNoah Misch <noah@leadboat.com>
Mon, 25 Nov 2024 22:42:40 +0000 (14:42 -0800)
commit2690a4f5ddf2974c322f48588ff6877ec2caade2
tree8300f53cbdc07cd2e9b9637b035fbe926c831f24
parent2fc0199a5015b520da75dddb76a169f6a568ef12
Avoid "you don't own a lock of type ExclusiveLock" in GRANT TABLESPACE.

This WARNING appeared because SearchSysCacheLocked1() read
cc_relisshared before catcache initialization, when the field is false
unconditionally.  On the basis of reading false there, it constructed a
locktag as though pg_tablespace weren't relisshared.  Only shared
catalogs could be affected, and only GRANT TABLESPACE was affected in
practice.  SearchSysCacheLocked1() callers use one other shared-relation
syscache, DATABASEOID.  DATABASEOID is initialized by the end of
CheckMyDatabase(), making the problem unreachable for pg_database.

Back-patch to v13 (all supported versions).  This has no known impact
before v16, where ExecGrant_common() first appeared.  Earlier branches
avoid trouble by having a separate ExecGrant_Tablespace() that doesn't
use LOCKTAG_TUPLE.  However, leaving this unfixed in v15 could ensnare a
future back-patch of a SearchSysCacheLocked1() call.

Reported by Aya Iwata.

Discussion: https://postgr.es/m/OS7PR01MB11964507B5548245A7EE54E70EA212@OS7PR01MB11964.jpnprd01.prod.outlook.com
src/backend/utils/cache/syscache.c
src/test/regress/input/tablespace.source
src/test/regress/output/tablespace.source