Fix use-after-free bug with AfterTriggersTableData.storeslot
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Sat, 27 Feb 2021 21:09:15 +0000 (18:09 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Sat, 27 Feb 2021 21:09:15 +0000 (18:09 -0300)
commit25936fd46c97039aad042ae8d46917d38d132fe4
tree0f6bc2824194a525c55abbe85173f43fef1452bc
parent388b959315205b0b65efb074ec84e1d7fad62402
Fix use-after-free bug with AfterTriggersTableData.storeslot

AfterTriggerSaveEvent() wrongly allocates the slot in execution-span
memory context, whereas the correct thing is to allocate it in
a transaction-span context, because that's where the enclosing
AfterTriggersTableData instance belongs into.

Backpatch to 12 (the test back to 11, where it works well with no code
changes, and it's good to have to confirm that the case was previously
well supported); this bug seems introduced by commit ff11e7f4b9ae.

Reported-by: Bertrand Drouvot <bdrouvot@amazon.com>
Author: Amit Langote <amitlangote09@gmail.com>
Discussion: https://postgr.es/m/39a71864-b120-5a5c-8cc5-c632b6f16761@amazon.com
src/backend/commands/trigger.c
src/test/regress/expected/triggers.out
src/test/regress/sql/triggers.sql