Fixes for ChangeVarNodes_walker()
authorAlexander Korotkov <akorotkov@postgresql.org>
Tue, 29 Apr 2025 11:34:44 +0000 (14:34 +0300)
committerAlexander Korotkov <akorotkov@postgresql.org>
Tue, 29 Apr 2025 11:34:44 +0000 (14:34 +0300)
commit2260c7f6d90ecf76d3806d32890a0890688b41e8
treeca339e2ad4f5db7da9c05b8b9f7e7ff6d83c9cdb
parent15b1b4dd3fccfd2576f44841863153c312de011b
Fixes for ChangeVarNodes_walker()

This commit fixes two bug in ChangeVarNodes_walker() function.

 * When considering RestrictInfo, walk down to its clauses based on the
   presense of relid to be deleted not just in clause_relids but also in
   required_relids.

 * Incrementally adjust num_base_rels based on the change of clause_relids
   instead of recalculating it using clause_relids, which could contain
   outer-join relids.

Reported-by: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/CAMbWs49PE3CvnV8vrQ0Dr%3DHqgZZmX0tdNbzVNJxqc8yg-8kDQQ%40mail.gmail.com
Author: Andrei Lepikhov <lepihov@gmail.com>
Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com>
src/backend/rewrite/rewriteManip.c
src/test/regress/expected/join.out
src/test/regress/sql/join.sql