Tidy-up some appendStringInfo*() usages
authorDavid Rowley <drowley@postgresql.org>
Tue, 3 Oct 2023 04:09:52 +0000 (17:09 +1300)
committerDavid Rowley <drowley@postgresql.org>
Tue, 3 Oct 2023 04:09:52 +0000 (17:09 +1300)
commit2075ba9dc9af8833b1147996c15246e44a1e4fab
treebe7b822bafcf2e6fdaf7a68b56f1458e868965c8
parent6b18b3fe2c2f375d4a5d8a69b67bc59d13d4c844
Tidy-up some appendStringInfo*() usages

Make a few newish calls to appendStringInfo() which have no special
formatting use appendStringInfoString() instead.  Also, adjust usages of
appendStringInfoString() which only append a string containing a single
character to make use of appendStringInfoChar() instead.

This makes the code marginally faster, but primarily this change is so
we use the StringInfo type as it was intended to be used.

Discussion: https://postgr.es/m/CAApHDvpXKQmL+r=VDNS98upqhr9yGBhv2Jw3GBFFk_wKHcB39A@mail.gmail.com
src/backend/access/rmgrdesc/heapdesc.c
src/backend/access/rmgrdesc/nbtdesc.c
src/backend/access/rmgrdesc/rmgrdesc_utils.c
src/backend/access/transam/xlogbackup.c
src/backend/replication/slot.c
src/backend/utils/adt/ruleutils.c
src/test/regress/pg_regress.c