Remove overzealous _bt_split() assertions.
authorPeter Geoghegan <pg@bowt.ie>
Tue, 3 Mar 2020 05:40:11 +0000 (21:40 -0800)
committerPeter Geoghegan <pg@bowt.ie>
Tue, 3 Mar 2020 05:40:11 +0000 (21:40 -0800)
commit1e07f5e0a1cf56f8cbc121dbb86c128a0f711c94
tree83fce88e21bd0cb1d55d212a6bce7895c5e9cb80
parent0b48f1335dddb7141160e392cccac98edfb3fa85
Remove overzealous _bt_split() assertions.

_bt_split() is passed NULL as its insertion scankey for internal page
splits.  Two recently added Assert() statements failed to consider this,
leading to a crash with pg_upgrade'd BREE_VERSION < 4 indexes.  Remove
the assertions.

The assertions in question were added by commit 0d861bbb, which added
nbtree deduplication.  It would be possible to fix the assertions
directly instead, but they weren't adding much anyway.
src/backend/access/nbtree/nbtinsert.c