Remove ineffective heapam CHECK_FOR_INTERRUPTS().
authorPeter Geoghegan <pg@bowt.ie>
Mon, 9 Nov 2020 17:00:12 +0000 (09:00 -0800)
committerPeter Geoghegan <pg@bowt.ie>
Mon, 9 Nov 2020 17:00:12 +0000 (09:00 -0800)
commit180cf876d457c260291af070d883c5db5033cb3a
tree9f9cc7560421edf48a527cb5e1b7f3e76f231a9d
parent098fb00799ffb026ff12c64bd21635f963cfc609
Remove ineffective heapam CHECK_FOR_INTERRUPTS().

Remove a CHECK_FOR_INTERRUPTS() call that could never actually handle an
interrupt.  We always have a heap page buffer lock at this point.
Having a useless CHECK_FOR_INTERRUPTS() call is harmless but misleading.

It is probably possible to work around the immediate problem by moving
the CHECK_FOR_INTERRUPTS() to before the heap page buffer lock is
acquired.  That isn't enough to make the function responsive to
interrupts, though.  The index AM caller will still hold an exclusive
buffer lock of its own.
src/backend/access/heap/heapam.c