projects / users / rhaas / postgres.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1c7a0b3) | patch
Fix fuzzy error handling in pg_basebackup when opening gzFile
authorMichael Paquier <michael@paquier.xyz>
Tue, 4 Feb 2020 04:56:04 +0000 (13:56 +0900)
committerMichael Paquier <michael@paquier.xyz>
Tue, 4 Feb 2020 04:56:04 +0000 (13:56 +0900)
commit177be9edf4bb966400db7769d61e479aa0fe0201
tree2b076f7315dc85b3ab5f5342195ddb5d72348f63tree
parent1c7a0b387d18c517d45e2f6ec7d8b7d1b2d5fe13commit | diff
Fix fuzzy error handling in pg_basebackup when opening gzFile

First, this code did not bother checking for a failure when calling
dup().  Then, per zlib, gzerror() returns NULL for a NULL input, which
can happen if passing down to gzdopen() an invalid file descriptor or if
there was an allocation failure.

No back-patch is done as this would unlikely be a problem in the field.

Per Coverity.

Reported-by: Tom Lane
src/bin/pg_basebackup/pg_basebackup.c diff | blob | blame | history
Robert Haas's development tree.