Refactor TAP test code for file comparisons into new routine in Utils.pm
authorMichael Paquier <michael@paquier.xyz>
Sun, 9 Feb 2025 07:52:33 +0000 (16:52 +0900)
committerMichael Paquier <michael@paquier.xyz>
Sun, 9 Feb 2025 07:52:33 +0000 (16:52 +0900)
commit169208092f5c98a6021b23b38f03a5d65f84ad96
treedaf82ede81714635c4143d605eeccb3d42eecd91
parentecb8226af63dc8f1c0859977102764704368693b
Refactor TAP test code for file comparisons into new routine in Utils.pm

This unifies the output used should any differences be found in the
files provided, information that 027_stream_regress did not show on
failures.  TAP tests of pg_combinebackup and pg_upgrade now rely on the
refactored routine, reducing the dependency to the diff command.  The
callers of this routine can optionally specify a custom line-comparison
function.

There are a couple of tests that still use directly a diff command:
001_pg_bsd_indent, 017_shm and test_json_parser's 003.  These rely on
different properties and are left out for now.

Extracted from a larger patch by the same author.

Author: Ashutosh Bapat
Discussion: https://postgr.es/m/Z6RQS-tMzGYjlA-H@paquier.xyz
src/bin/pg_combinebackup/t/002_compare_backups.pl
src/bin/pg_upgrade/t/002_pg_upgrade.pl
src/test/perl/PostgreSQL/Test/Utils.pm
src/test/recovery/t/027_stream_regress.pl